Skip to content

Superboogav2 Quick Fixes#5089

Merged
oobabooga merged 20 commits into
oobabooga:devfrom
TheInvisibleMage:SBv2NameQuickFix
Dec 31, 2023
Merged

Superboogav2 Quick Fixes#5089
oobabooga merged 20 commits into
oobabooga:devfrom
TheInvisibleMage:SBv2NameQuickFix

Conversation

@TheInvisibleMage
Copy link
Copy Markdown
Contributor

@TheInvisibleMage TheInvisibleMage commented Dec 27, 2023

Description:

  • A super small PR adding a few small fixes to allow Superboogav2 to run out of the box.
    • Slightly increase the resilience of the "_get_names" function by assigning default names first, then allowing overrides if they are present. Also logs a warning if an override is not found.
    • Modify the Notebook Handler to use the existing "is_chat" param, instead of the "shared.is_chat" value, which is at present always true regardless of actual chat status.

Checklist:

@TheInvisibleMage TheInvisibleMage changed the title S bv2 name quick fix Superboogav2 Quick Fixes Dec 27, 2023
Comment thread extensions/superboogav2/chat_handler.py Outdated
@oobabooga
Copy link
Copy Markdown
Owner

Thank you for the fixes. I haven't tested this extension in a while and it's nice to get an update.

@oobabooga oobabooga merged commit 485b85e into oobabooga:dev Dec 31, 2023
@TheInvisibleMage TheInvisibleMage deleted the SBv2NameQuickFix branch December 31, 2023 12:21
PoetOnTheRun pushed a commit to PoetOnTheRun/text-generation-webui that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants